Off-by-one in $obj->asGif after upgrading to ACEDB_4.9s

Ed Griffiths edgrif at sanger.ac.uk
Tue Sep 9 07:48:21 EST 2003


Morten,

> After upgrading to ACEDB_4.9s, sgifserver seems to provide gif-images
> where the first byte is NULL and the last byte is dropped.
> 
> AcePerl now outputs faulty gifs with the obj->asGif method (Object.pm). As
> AcePerl has not changed, and giface client produces good gifs I assume
> something changed in sgifserver. Anyone else seen this?
> 
> I also tested 4.9u with same results.
> Compiled with gcc 3.2.2 on Linux RH9, -O2/-03 optimation.

I have looked into this and its been caused by a change to a low level routine
in acedb changing which resulted in a null byte being inserted in front of the
GIF image in the datastream. I think you see the last byte dropped because the
aceperl code is now one byte out.

I am checking with Lincoln what we should do about this, the null byte in the
datastream makes some sense in fact so the answer may be to change the aceperl
code to handle it.

Once its fixed I'll put a note here.

Ed
-- 
 ------------------------------------------------------------------------
| Ed Griffiths, Acedb development, Informatics Group,                    |
|        Wellcome Trust Sanger Institute, Wellcome Trust Genome Campus,  |
|               Hinxton, Cambridge CB10 1SA, UK                          |
|                                                                        |
| email: edgrif at sanger.ac.uk  Tel: +44-1223-494780  Fax: +44-1223-494919 |
 ------------------------------------------------------------------------





More information about the Acedb mailing list